wu-sheng commented on code in PR #146: URL: https://github.com/apache/skywalking-java/pull/146#discussion_r847898118
########## apm-sniffer/bootstrap-plugins/jdk-threadpool-plugin/src/main/java/org/apache/skywalking/apm/plugin/wrapper/SwRunnableWrapper.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * +*/ + +package org.apache.skywalking.apm.plugin.wrapper; + +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.ContextSnapshot; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; + +public class SwRunnableWrapper implements Runnable { + + private Runnable runnable; + + private ContextSnapshot contextSnapshot; + + public SwRunnableWrapper(Runnable runnable, ContextSnapshot contextSnapshot) { + this.runnable = runnable; + this.contextSnapshot = contextSnapshot; + } + + @Override + public void run() { + AbstractSpan span = ContextManager.createLocalSpan(getOperationName()); Review Comment: One more scenario to discussion, The ThreadPoolExecutor could be used to run an endless loop task, like a timer. And `run` method would never end. As you mentioned using the class name to filter in meter collection, should we add this kind of mechanism in the tracing part too? (Have to back about caller detection, as user could use APIs rather than inherit from this) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
