Cool-Coding commented on code in PR #146:
URL: https://github.com/apache/skywalking-java/pull/146#discussion_r848082194
##########
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java:
##########
@@ -130,6 +130,8 @@ public static void premain(String agentArgs,
Instrumentation instrumentation) th
.with(new Listener())
.installOn(instrumentation);
+ SnifferConfigInitializer.pluginInitCompleted();
Review Comment:
>
`PluginFinder` is responsible for loadplugins and matching classes.
`AgentBuilder` is responsible for transforming classes.
`IS_PLUGIN_INIT_COMPLETED` must be set true after `AgentBuilder.
installOn(instrumentation)`. Maybe the variable field name is not very
appropriate. ` IS_PLUGIN_INSTALLED_COMPLETED` maybe more appropriate. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
