wankai123 commented on code in PR #8917:
URL: https://github.com/apache/skywalking/pull/8917#discussion_r854865818
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/server/HTTPHandlerRegister.java:
##########
@@ -18,8 +18,10 @@
package org.apache.skywalking.oap.server.core.server;
+import com.linecorp.armeria.common.HttpMethod;
+import java.util.List;
import org.apache.skywalking.oap.server.library.module.Service;
public interface HTTPHandlerRegister extends Service {
- void addHandler(Object httpService);
+ void addHandler(Object httpService, List<HttpMethod> allowedMethods);
Review Comment:
`allowedMethods` of course the server level, but when the handlers share the
server, only themselves know provide which methods. So I think it's should send
this info to the server when registering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
