kezhenxu94 commented on code in PR #8982:
URL: https://github.com/apache/skywalking/pull/8982#discussion_r864418983
##########
.github/workflows/skywalking.yaml:
##########
@@ -568,22 +607,26 @@ jobs:
timeout-minutes: 10
steps:
- name: Merge Requirement
+ # check changes, sanity, dependency license, unit, integration, e2e,
e2e-istio and e2e-java-versions,
+ # if all of them are working as expected then naturally exits else
return error code
Review Comment:
Exit with different codes in different failures looks a good practice but I
don’t think it useful here as the failed tasks will be already red in the
workflow so we don’t bother clicking into the detail to see the exit code. And
it looks the logic becomes kinda verbose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
