This is an automated email from the ASF dual-hosted git repository.

lujiajing pushed a commit to branch 
fix-profile-thread-snapshot-record-conversion
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to 
refs/heads/fix-profile-thread-snapshot-record-conversion by this push:
     new 289c0461a9 fix conversion
289c0461a9 is described below

commit 289c0461a9848d2b9a1c8a75a2c6908dfd51eb74
Author: Megrez Lu <[email protected]>
AuthorDate: Wed May 4 11:50:43 2022 +0800

    fix conversion
---
 .../server/core/profiling/trace/ProfileThreadSnapshotRecord.java | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileThreadSnapshotRecord.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileThreadSnapshotRecord.java
index a66633a797..6d9d9bf67e 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileThreadSnapshotRecord.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileThreadSnapshotRecord.java
@@ -31,6 +31,7 @@ import 
org.apache.skywalking.oap.server.core.storage.annotation.Column;
 import 
org.apache.skywalking.oap.server.core.storage.annotation.QueryUnifiedIndex;
 import org.apache.skywalking.oap.server.core.storage.type.Convert2Entity;
 import org.apache.skywalking.oap.server.core.storage.type.Convert2Storage;
+import org.apache.skywalking.oap.server.core.storage.type.HashMapConverter;
 import org.apache.skywalking.oap.server.core.storage.type.StorageBuilder;
 import org.apache.skywalking.oap.server.library.util.StringUtil;
 
@@ -81,11 +82,7 @@ public class ProfileThreadSnapshotRecord extends Record {
             snapshot.setDumpTime(((Number) 
converter.get(DUMP_TIME)).longValue());
             snapshot.setSequence(((Number) 
converter.get(SEQUENCE)).intValue());
             snapshot.setTimeBucket(((Number) 
converter.get(TIME_BUCKET)).intValue());
-            if (StringUtil.isEmpty((String) converter.get(STACK_BINARY))) {
-                snapshot.setStackBinary(new byte[] {});
-            } else {
-                snapshot.setStackBinary(Base64.getDecoder().decode((String) 
converter.get(STACK_BINARY)));
-            }
+            snapshot.setStackBinary(converter.getWith(STACK_BINARY, 
HashMapConverter.ToEntity.Base64Decoder.INSTANCE));
             return snapshot;
         }
 
@@ -96,7 +93,7 @@ public class ProfileThreadSnapshotRecord extends Record {
             converter.accept(DUMP_TIME, storageData.getDumpTime());
             converter.accept(SEQUENCE, storageData.getSequence());
             converter.accept(TIME_BUCKET, storageData.getTimeBucket());
-            converter.accept(STACK_BINARY, new 
String(Base64.getEncoder().encode(storageData.getStackBinary())));
+            converter.accept(STACK_BINARY, storageData.getStackBinary());
         }
     }
 }

Reply via email to