kezhenxu94 edited a comment on issue #3106: Use CopyOnWriteArrayList instead of recreating manually URL: https://github.com/apache/skywalking/pull/3106#issuecomment-512308716 FYI @wu-sheng , I'm recently considering whether we should create a new module/directory to place all the benchmark tests like other projects, the reasons are: 1. we have some benchmarks that are independent to any existed module, such as `LinkedArrayBenchmark`, `StringFormatBenchmarkTest`, IMHO they should be placed in an independent module, otherwise it's hard for new-comers to refer to and find out whether we already have that benchmark or not 2. some of the existed benchmarks are annotated with `@Test`, and are executed in maven test phase (I think), which is not necessary and time consuming, gathering them together may be easy to manage and remove `@Test` Just a bold thought and may make no sense at all :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
