qxo commented on issue #3122: improve MethodsAroundInterceptor API:add MethodAroundContext over the Interceptor … URL: https://github.com/apache/skywalking/pull/3122#issuecomment-513427584 I agree the API should not change if necessary On my point of view, the API should change for the future This PR try to make the API strong: pass span over MethodAroundContext and then call `ContextManager#stopSpan(span)` -- the fail-fast version of stopSpan combine with #3124( "span carrry TracingContext" , reduce call ThreadLocal if not required ) will improve the performance additionally
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
