wu-sheng commented on a change in pull request #2973: Support etcd
configuration.
URL: https://github.com/apache/skywalking/pull/2973#discussion_r305573242
##########
File path: oap-server/pom.xml
##########
@@ -378,11 +382,75 @@
<artifactId>nacos-client</artifactId>
<version>${nacos.version}</version>
</dependency>
+
<dependency>
<groupId>org.mousio</groupId>
<artifactId>etcd4j</artifactId>
+ <exclusions>
+ <exclusion>
+ <artifactId>netty-codec-dns</artifactId>
+ <groupId>io.netty</groupId>
+ </exclusion>
+
+ <exclusion>
+ <artifactId>netty-codec-dns</artifactId>
+ <groupId>io.netty</groupId>
+ </exclusion>
+
+ <exclusion>
+ <artifactId>netty-codec-http</artifactId>
+ <groupId>io.netty</groupId>
+ </exclusion>
+
+ <exclusion>
+ <artifactId>netty-handler</artifactId>
+ <groupId>io.netty</groupId>
+ </exclusion>
+
+ <exclusion>
+ <artifactId>netty-resolver-dns</artifactId>
+ <groupId>io.netty</groupId>
+ </exclusion>
+
+ <exclusion>
+ <groupId>com.fasterxml.jackson.module</groupId>
+ <artifactId>jackson-module-afterburner</artifactId>
+ </exclusion>
+ </exclusions>
<version>${etcd4j.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-handler</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-resolver-dns</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-dns</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.netty</groupId>
+ <artifactId>netty-codec-http</artifactId>
+ <version>${netty.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.fasterxml.jackson.module</groupId>
+ <artifactId>jackson-module-afterburner</artifactId>
+ <version>${jackson-module-afterburner.version}</version>
Review comment:
Where are the licenses of these? I think you haven't updated the dist
LICENSE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
