Duncan-tree-zhou commented on code in PR #66: URL: https://github.com/apache/skywalking-swck/pull/66#discussion_r902715575
########## docs/java-agent-injector.md: ########## @@ -44,14 +44,20 @@ inject-demo 1/1 Running 0 2d2h The java agent injector supports a precedence order to configure the agent: -``` Annotations > Configmap > Default configmap``` +``` Annotations > SwAgent CR > Configmap > Default configmap``` Review Comment: I think removing agent.config configmap would cause many changes. i don't know if simply removing the `skywalking-swck-java-agent-configmap` volume would work. it looks like that we should also add the default file into agent image. Maybe we can open another issue to discuss about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
