qxo opened a new issue #3135: createEntrySpan should get SamplingService only if it required ( carrier is valid: move #L90 after #L93 ) URL: https://github.com/apache/skywalking/issues/3135 https://github.com/apache/skywalking/blob/c7916d9f2715ff9d3c415f86418d8f81c97a21e7/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java#L90 https://github.com/apache/skywalking/blob/c7916d9f2715ff9d3c415f86418d8f81c97a21e7/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ContextManager.java#L93 ``` public static AbstractSpan createEntrySpan(String operationName, ContextCarrier carrier) { SamplingService samplingService = ServiceManager.INSTANCE.findService(SamplingService.class); AbstractSpan span; AbstractTracerContext context; if (carrier != null && carrier.isValid()) { samplingService.forceSampled(); context = getOrCreate(operationName, true); span = context.createEntrySpan(operationName); context.extract(carrier); } else { context = getOrCreate(operationName, false); span = context.createEntrySpan(operationName); } return span; } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
