kezhenxu94 commented on code in PR #88: URL: https://github.com/apache/skywalking-kubernetes/pull/88#discussion_r910824774
########## chart/skywalking/templates/es-init.job.yaml: ########## @@ -15,7 +15,7 @@ # https://docs.sentry.io/server/installation/docker/#running-migrations -{{- if contains "elasticsearch" .Values.oap.storageType }} +{{- if and .Values.oap.initEs (contains "elasticsearch" .Values.oap.storageType) -}} Review Comment: The CI failed perhaps because of this (not sure tho) ```suggestion {{- if and .Values.oap.initEs (contains "elasticsearch" .Values.oap.storageType) }} ``` ########## chart/skywalking/values.yaml: ########## @@ -37,6 +37,7 @@ oap: tag: null # Must be set explicitly pullPolicy: IfNotPresent storageType: null + initEs: true # Whether need to initial ES Review Comment: Please add this to doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
