wayilau commented on issue #2644: Support Hessian 4.0.x.
URL: https://github.com/apache/skywalking/pull/2644#issuecomment-514021185
 
 
   > I am not a hession user, too. But 
`org.springframework.remoting.caucho.HessianServiceExporter` looks like not 
right indeed. @wayilau Why do you need to choose a Spring framework class? For 
most Spring components, they are just bridges, a hession-core level 
instrumentation should be enough. But if there is an exception, please make it 
clear to us.
   > 
   > Basically, I think @kezhenxu94 get the point, it should work w/ and w/o 
Spring both like other plugins did.
   
   @wu-sheng @kezhenxu94  
   Yes , I give an spring instrumentation, because last month I give the patch, 
but the tag is the class name in the server side. you tell me that tags name 
misunderstood so I supplied a flag when true use the url tag, use class name 
when it is false. I can not get the url, so use the hessianserviceexporter, as 
@kezhenxu94 said hessian may use in nomal java application, but the all use 
Servlet, i think so. what 's you idea ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to