kezhenxu94 commented on issue #2644: Support Hessian 4.0.x. URL: https://github.com/apache/skywalking/pull/2644#issuecomment-514050365 > I shoud add an instrumentation for HessianServlet ? am i right ? @kezhenxu94 > In springboot it doesn't use HessianServlet, it just uses HessianServiceExporter. so I give two instrumentation, it is enough? I'm afraid that's not the case. Spring doesn't use `HessianServlet` indeed, but it uses `HessianSkeleton` (`org.springframework.remoting.caucho.HessianExporter#doInvoke`), `HessianServlet` also uses `HessianSkeleton` (`com.caucho.hessian.server.HessianServlet#invoke`), and it seems that you have already instrumented `HessianSkeleton`, so perhaps you can instrument `HessianSkeleton` and use SkyWalking dynamic field (or something similar) to keep the url (if any) in one request through the instrumented classes. To summarize, I think class `HessianSkeleton` is the core of hessian, which should be used by any other frameworks that integrate with hessian, such as Spring, and instrumenting it should work with/wihout third-party frameworks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
