Duncan-tree-zhou commented on PR #66:
URL: https://github.com/apache/skywalking-swck/pull/66#issuecomment-1208037028

   Ok, I think I get your idea. But do you think it's a little bit comlicated 
way to config optional plugins? How about remove and hard code `sharedVolume. 
mountPath` , and generate the sharedVolumn mountPaths by "optionalPlugins".
   
   ```
   apiVersion: operator.skywalking.apache.org/v1alpha1
   kind: SwAgent
   metadata:
     name: swagent-001
     namespace: skywalking-system
   spec:
     containerMatcher: ''
     selector:
     javaSidecar:
       name: swagent-001
       image: 
ghcr.io/apache/skywalking-java/skywalking-java:f8deb7c30b931aae83ac1f438ce72b3f74414ae5-java8
       env:
         - name: "SW_LOGGING_LEVEL"
           value: "DEBUG"
         - name: "SW_AGENT_COLLECTOR_BACKEND_SERVICES"
           value: "skywalking-system-oap:11800"
     sharedVolumeName: "sky-agent-test-001" ## default is sky-agent
     swConfigMapVolume:
          name:  "apm-customize-enhance-plugin"
          configMapName: "customize-enhance-config"
          configMapMountPath: "/absolute/path/to/customize_enhance.xml"
     optionalPlugins:
       - "plugin1"
       - "plugin2"
   ```
   
   
   than we get injection mount in pod
   
   ```
       -  name: "sky-agent-optional-plugin-plugin1"
           mountPath: "/path/to/optional/plugin/plugin1"
       -  name: "sky-agent-optional-plugin-plugin2"
           mountPath: "/path/to/optional/plugin/plugin2"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to