lujiajing1126 commented on code in PR #153:
URL:
https://github.com/apache/skywalking-banyandb/pull/153#discussion_r940794937
##########
banyand/kv/kv.go:
##########
@@ -160,6 +171,9 @@ func OpenTimeSeriesStore(shardID int, path string, options
...TimeSeriesOptions)
}
// Put all values into LSM
btss.dbOpts = btss.dbOpts.WithVLogPercentile(1.0)
+ if btss.dbOpts.MemTableSize < 8<<20 {
Review Comment:
`8<<20` seems to be a magic number... What does it mean?
##########
banyand/kv/kv.go:
##########
@@ -126,6 +126,17 @@ func TSSWithFlushCallback(callback func())
TimeSeriesOptions {
}
}
+func TSSWithMemTableSize(size int64) TimeSeriesOptions {
+ return func(store TimeSeriesStore) {
+ if size < 1 {
Review Comment:
Do we have some minimal requirement for the mem table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
