wu-sheng commented on code in PR #155:
URL:
https://github.com/apache/skywalking-banyandb/pull/155#discussion_r946371353
##########
api/proto/banyandb/model/v1/query.proto:
##########
@@ -68,8 +72,21 @@ message Condition {
// tag_families are indexed.
message Criteria {
- string tag_family_name = 1;
- repeated model.v1.Condition conditions = 2;
+ repeated Expression exps = 1;
Review Comment:
I want to recheck here too. If Expression is planned to support nested, then
Expression should be a hierarchy structure, rather than a `repeated`. This
seems an intermediate status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
