wu-sheng commented on a change in pull request #3162: Simplify the PxxMetrics
and ThermodynamicMetrics to improve performance
URL: https://github.com/apache/skywalking/pull/3162#discussion_r307136633
##########
File path:
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/PersistenceColumns.java
##########
@@ -43,7 +43,7 @@ public void addIntField(String fieldName) {
intFields.add(new PersistenceField(fieldName));
}
- public void addIntLongValuePairelistField(String fieldName) {
+ public void addIntKeyLongValueHashMapField(String fieldName) {
intLongValuePairListFields.add(new PersistenceField(fieldName));
Review comment:
This field name should be changed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
