wu-sheng commented on a change in pull request #3145: Fixed java agent cannot
trace gRPC stream service
URL: https://github.com/apache/skywalking/pull/3145#discussion_r307142476
##########
File path:
apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/StreamCallClientInterceptor.java
##########
@@ -124,8 +132,12 @@ protected CallListener(Listener delegate, ContextSnapshot
contextSnapshot) {
} else {
AbstractSpan abstractSpan =
ContextManager.createLocalSpan(operationPrefix +
STREAM_RESPONSE_OBSERVER_ON_COMPLETE_OPERATION_NAME);
}
- delegate().onClose(status, trailers);
ContextManager.continued(contextSnapshot);
+ } catch (Throwable t) {
+ // ignore trace error
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
