jiang1997 commented on code in PR #231: URL: https://github.com/apache/skywalking-python/pull/231#discussion_r952754597
########## skywalking/agent/__init__.py: ########## @@ -37,7 +38,7 @@ __started = False __protocol = Protocol() # type: Protocol __heartbeat_thread = __report_thread = __log_report_thread = __query_profile_thread = __command_dispatch_thread \ - = __send_profile_thread = __queue = __log_queue = __snapshot_queue = __finished = None + = __send_profile_thread = meter_service_thread = __queue = __log_queue = __snapshot_queue = __finished = None Review Comment: I tried to name ``meter_service_thread`` as ``__meter_service_thread`` to comply with the naming convention here. But only to find that double underscore has its own specific behaviour when importing double underscore variable from another file. More details here. https://stackoverflow.com/questions/1301346/what-is-the-meaning-of-single-and-double-underscore-before-an-object-name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
