kezhenxu94 commented on code in PR #9575: URL: https://github.com/apache/skywalking/pull/9575#discussion_r965440062
########## docs/en/concepts-and-designs/lal.md: ########## @@ -10,7 +10,7 @@ activate specific LAL config files. ## Filter -A filter is a group of [parser](#parser), [extractor](#extractor) and [sink](#sink). Users can use one or more filters +A filter is a group of [parser](#parser), [extractor](#extractor), [SlowSql](#slowsql) and [sink](#sink). Users can use one or more filters Review Comment: I'd expect `extractor` to includes all operations that extract other things than log itself, can you move the `slowSql` into `extractor`, like `metrics` extractor? By doing this, we can reuse the logics like, service name, instance name, timestamp, layer, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
