kezhenxu94 commented on issue #3178: Fix bug that {Minute,Hour}TTLCalculator
use wrong time unit
URL: https://github.com/apache/skywalking/pull/3178#issuecomment-515750911
> In today's ES storage, the ES Hour/Minute level metrics are deleted
through day level TTL.
I know that, and the `EsHourTTLCalculator` truncates the date format to
`yyyyMMdd`. But the calculation is wrong IMHO:
https://github.com/apache/skywalking/blob/5036e8334301322d49973005cd98513c17b0f28f/oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/ttl/EsHourTTLCalculator.java#L30
For example, `timeBefore` 20190728 18:00:00 with
`DataTTLConfig#hourMetricsDataTTL=3` should return `20190728`, but it actually
returns `20190725`, which I think will keep more old data than expected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
