kezhenxu94 opened a new pull request #3181: Fix bug: state not updated when 
GRPC auto reconnect to the same server
URL: https://github.com/apache/skywalking/pull/3181
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   ___
   ### Bug fix
   - Bug description.
   Most of the components (such as ServiceAndEndpointRegisterClient) depend on 
the status change callback 
org.apache.skywalking.apm.agent.core.remote.GRPCChannelListener#statusChanged 
(triggered by notify line 106), if there is only one OAP node and it's 
restarting, the status would be DISCONNECTED and never change back to 
CONNECTED, all the components depends on the status won't work since then
   
   - How to fix?
   avoid recreating a new channel every time (yet take the advantage of GRPC's 
auto-reconnectivity) when there is only one server, by checking the existed 
channel's state.
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to