wu-sheng commented on code in PR #9622: URL: https://github.com/apache/skywalking/pull/9622#discussion_r973718182
########## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/VirtualCacheAccess.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.source; + +import lombok.Getter; +import lombok.Setter; +import org.apache.skywalking.oap.server.core.analysis.IDManager; + +import static org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.CACHE_ACCESS; +import static org.apache.skywalking.oap.server.core.source.DefaultScopeDefine.SERVICE_CATALOG_NAME; + +@ScopeDeclaration(id = CACHE_ACCESS, name = "VirtualCacheAccess", catalog = SERVICE_CATALOG_NAME) [email protected](fieldName = "entityId", columnName = "entity_id", isID = true, type = String.class) +public class VirtualCacheAccess extends Source { + + @Override + public int scope() { + return CACHE_ACCESS; + } + + @Override + public String getEntityId() { + return IDManager.ServiceID.buildId(name, false); + } + + @Getter + @Setter + @ScopeDefaultColumn.DefinedByField(columnName = "name", requireDynamicActive = true) + private String name; + @Getter + @Setter + private int cacheTypeId; + @Getter + @Setter + private int latency; + @Getter + @Setter + private boolean status; + @Getter + @Setter + private String op; // operation Review Comment: ```suggestion /** * op represents an operation of this cache access. */ @Getter @Setter private String op; ``` If you want to provide a comment, please provide details and for the field. Also, I recommend using an enum rather than a string, it has higher performance and is harder to mis-set. Refer `RequestType` which is in many sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
