wu-sheng commented on PR #9681: URL: https://github.com/apache/skywalking/pull/9681#issuecomment-1257156755
Currently, the boundaries of APIs are not clear. As I mentioned in the discussion. the module manager should never include the watcher mechanism into the core, no matter in any case. And the `ModuleConfigMutator` is not necessary. Also in the previous discussion, you proposed an interface to config the initializer to create an instance. But you seem to change all the things from the discussion. The previous discussion lost the whole point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
