wu-sheng commented on code in PR #9711:
URL: https://github.com/apache/skywalking/pull/9711#discussion_r983621606
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/general/general-instance.json:
##########
@@ -1012,6 +1012,230 @@
}
}
]
+ },
+ {
+ "name": "Golang",
+ "children": [
+ {
+ "x": 0,
+ "y": 0,
+ "w": 8,
+ "h": 13,
+ "i": "15",
+ "type": "Widget",
+ "widget": {
+ "title": "Heap Memory (MB)"
+ },
+ "graph": {
+ "type": "Line",
+ "step": false,
+ "smooth": false,
+ "showSymbol": false,
+ "showXAxis": true,
+ "showYAxis": true
+ },
+ "metrics": [
+ "meter_instance_golang_heap"
+ ],
+ "metricTypes": [
+ "readMetricsValues"
+ ],
+ "metricConfig": [
+ {
+ "calculation": "byteToMB"
+ }
+ ],
+ "moved": false
+ },
+ {
+ "x": 8,
+ "y": 0,
+ "w": 8,
+ "h": 13,
+ "i": "16",
+ "type": "Widget",
+ "widget": {
+ "title": "Stack Memory (MB)"
+ },
+ "graph": {
+ "type": "Line",
+ "step": false,
+ "smooth": false,
+ "showSymbol": false,
+ "showXAxis": true,
+ "showYAxis": true
+ },
+ "metrics": [
+ "meter_instance_golang_stack"
+ ],
+ "metricTypes": [
+ "readMetricsValues"
+ ],
+ "metricConfig": [
+ {
+ "calculation": "byteToMB"
+ }
+ ],
+ "moved": false
+ },
+ {
+ "x": 16,
+ "y": 0,
+ "w": 8,
+ "h": 13,
+ "i": "17",
+ "type": "Widget",
+ "widget": {
+ "title": "Golang GC Time (ms)"
+ },
+ "graph": {
+ "type": "Line",
+ "step": false,
+ "smooth": false,
+ "showSymbol": false,
+ "showXAxis": true,
+ "showYAxis": true
+ },
+ "metrics": [
+ "meter_instance_golang_gc_time"
+ ],
+ "metricTypes": [
+ "readMetricsValues"
+ ],
+ "metricConfig": [
+ {
+ "calculation": "nanosecondToMillisecond"
+ }
+ ],
+ "moved": false
+ },
+ {
+ "x": 0,
+ "y": 13,
+ "w": 8,
+ "h": 13,
+ "i": "18",
+ "type": "Widget",
+ "widget": {
+ "title": "Golang GC Count"
Review Comment:
```suggestion
"title": "Golang GC Count Per Minute"
```
This seems actually the real meaning of this metric if you report this per
minute.
In hour/day level, the gc_count(increase) would still get `avg`
downsampling. We always get a `count/min`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
