kezhenxu94 commented on code in PR #9725: URL: https://github.com/apache/skywalking/pull/9725#discussion_r985253998
########## docs/en/concepts-and-designs/mal.md: ########## @@ -155,16 +155,16 @@ resulting in a new sample family having fewer samples (sometimes having just a s - max (select maximum over dimensions) - avg (calculate the average over dimensions) -These operations can be used to aggregate overall label dimensions or preserve distinct dimensions by inputting `by` parameter. +These operations can be used to aggregate overall label dimensions or preserve distinct dimensions by inputting `by` parameter( the keyword `by` could be omitted) ``` -<aggr-op>(by: <tag1, tag2, ...>) +<aggr-op>(by=<tag1, tag2, ...>) Review Comment: ```suggestion <aggr-op>(by=[<tag1>, <tag2>, ...]) ``` ########## test/e2e-v2/cases/apisix/expected/endpoint.yml: ########## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +{{- contains . }} +- id: YXBpc2l4OjphcGlzaXgtc2VyZXI6OTA5MQ==.1_cm91dGVzIzE= Review Comment: Let's use 👇 for better readability ```suggestion - id: {{ b64enc "apisix::apisix-serer:9091" }}.1_{{ b64enc "routes#1" }} ``` ########## test/e2e-v2/cases/apisix/otel-collector/otel-collector-config.yaml: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +receivers: + prometheus: + config: + scrape_configs: + - job_name: 'apisix-monitoring' + scrape_interval: 1s + metrics_path: "/apisix/prometheus/metrics" + static_configs: + - targets: ['apisix-serer:9091'] +processors: + batch: + +exporters: + otlp: + endpoint: oap:11800 + tls: + insecure: true +service: + pipelines: + metrics: + receivers: + - prometheus + processors: + - batch + exporters: + - otlp Review Comment: Let's add a logging exporter with debug level so when it failed we can have some logs to diagnose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
