ZEALi opened a new pull request, #242: URL: https://github.com/apache/skywalking-python/pull/242
span.component should not be started as an Enum instead of a int 0. integer 0 will be invalid if we just new_entry_span() without any further setting for span.component. <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin --> <!-- - [ ] Add a test case for the new plugin - [ ] Add a CHANGELOG entry for the new plugin - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml) - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies) - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh` - [ ] Rebuild the `Plugins.md` documentation by running `make doc-gen` --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
