aiyanbo commented on a change in pull request #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#discussion_r309115306
########## File path: apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/undertow/v2x/util/TraceContextUtils.java ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.skywalking.apm.plugin.undertow.v2x.util; + +import io.undertow.server.HttpServerExchange; +import io.undertow.util.HeaderMap; +import org.apache.skywalking.apm.agent.core.context.CarrierItem; +import org.apache.skywalking.apm.agent.core.context.ContextCarrier; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.tag.Tags; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; + +import java.util.concurrent.atomic.AtomicBoolean; + +/** + * @author AI + * 2019-07-26 + */ +public class TraceContextUtils { + + private static final AtomicBoolean IS_IN_ROUTING_HANDLER_TRACE = new AtomicBoolean(false); Review comment: > Could we make the binding happens once? Or this keeps in uncertain status. No, we cannot. When undertow using `RoutingHandler` it will binding to `RoutingHandlerInterceptor` ``` RoutingHandler handler = new RoutingHandler(); // RoutingHandlerInterceptor's cutpoint is add method handler.add(Methods.GET, "/projects/{projectId}", exchange -> { exchange.getResponseHeaders().put(Headers.CONTENT_TYPE, "text/plain"); exchange.getResponseSender().send("Hello World"); }); Undertow server = Undertow.builder().setHandler(handler)... ``` or using `HttpHandler` it will binding to `ExecuteRootHandlerInterceptor` ``` io.undertow.server.Connectors.executeRootHandler Undertow.builder().setHandler(new HttpHandler() { @Override public void handleRequest(HttpServerExchange httpServerExchange) throws Exception { // } }); ``` We cannot detected user how to use `undertow`. So we need keep `ExecuteRootHandlerInterceptor` and `RoutingHandlerInterceptor` both. > These two in different threads? Maybe, `HttpServerExchange` can dispatched to other `Executor`. > If in the same thread, these two should be merged automatically. EntrySpan 1: /projects/1 EntrySpan 2: /projects/{projectId} it can merged automatically? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
