yswdqz opened a new pull request, #9822:
URL: https://github.com/apache/skywalking/pull/9822

   When setting the level for MAL metrics, using the service and instance 
methods for each metric will generate a lot of redundant code.
   We can use MAL's "expSuffix" to avoid it, but because the "expSuffix" 
required by the instance level metric and the service level metric is 
different, it will inevitably lead to file splitting (mysql.yaml -> 
mysql-instance.yaml + mysql-service.yaml )
   So I changed the loading method of MAL files to be folder based to 
facilitate future expansion.
   
   I haven't updated the dicyet because I think maybe somewhere needs to be 
modified.
   
   ### <Feature description>
   - [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [ ] If it's UI related, attach the screenshots below.
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to