wu-sheng commented on a change in pull request #3170: Support upgrade backend 
w/o rebooting agents
URL: https://github.com/apache/skywalking/pull/3170#discussion_r309751220
 
 

 ##########
 File path: test/e2e/e2e-agent-reboot/pom.xml
 ##########
 @@ -84,6 +84,7 @@
                             <run>
                                 <env>
                                     
<INSTRUMENTED_SERVICE>${project.build.finalName}.jar</INSTRUMENTED_SERVICE>
+                                    
<INSTRUMENTED_SERVICE_OPTS>-DSW_AGENT_COOL_DOWN_THRESHOLD=1</INSTRUMENTED_SERVICE_OPTS>
 
 Review comment:
   How this opt works? If you use `-D`, then it should be `skywalking.agent. 
cool_down_threshold`, right?
   
   Your own document says so too
   > `agent.cool_down_threshold `|How long should the agent wait (in minute) 
before re-registering to the OAP server after receiving reset command.|`10`|

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to