jmjoy commented on code in PR #26:
URL: https://github.com/apache/skywalking-php/pull/26#discussion_r1002939840
##########
src/module.rs:
##########
@@ -61,14 +56,30 @@ pub fn init(_module: ModuleContext) -> bool {
service_instance, skywalking_version, "Starting skywalking agent"
);
+ let worker_addr = {
+ match tempfile::NamedTempFile::new() {
Review Comment:
The `NamedTempFile` will be deleted after the `init` function finished.
How about wrap it with `ManuallyDrop` and manual drop it in `shutdown`
function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
