wu-sheng commented on code in PR #9822:
URL: https://github.com/apache/skywalking/pull/9822#discussion_r1003358427
##########
oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/ResourceUtils.java:
##########
@@ -90,4 +90,13 @@ private static List<File> getDirectoryFilesRecursive(String
directoryPath, List<
}
return fileList;
}
+
+ public static File[] getAllPathFiles(String path) throws
FileNotFoundException {
Review Comment:
```suggestion
public static File[] list(String path) throws FileNotFoundException {
```
I think we should follow Java-style to use `list`? `getAllPathFiles` seems
very tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
