wu-sheng commented on PR #9620: URL: https://github.com/apache/skywalking/pull/9620#issuecomment-1296678495
@wankai123 @kezhenxu94 @mrproliu I received @liuhaoyang 's messages, this PR should be functional and working. Please take a deeper review. This is his local testing. (Those two red rectangles are difference metrics from two metric sources.) <img width="1512" alt="image" src="https://user-images.githubusercontent.com/5441976/198950670-56b0a5c1-beff-4f4a-9bf5-b6b6e2e9ecb9.png";> @soander @liuhaoyang It is good to see this is getting improved, we need more time to get this ready for the upstream user. Considering this is a new protocol integration, we must be a little more cautious。 I know this may relate to Summer 2022 program somehow, if there is anything that needs my collaboration with the committee, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/5441976/198950670-56b0a5c1-beff-4f4a-9bf5-b6b6e2e9ecb9.png"](https://user-images.githubusercontent.com/5441976/198950670-56b0a5c1-beff-4f4a-9bf5-b6b6e2e9ecb9.png"){kind=link}