Superskyyy commented on code in PR #208:
URL:
https://github.com/apache/skywalking-banyandb/pull/208#discussion_r1018549142
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
See a case here
https://github.com/apache/skywalking/actions/runs/3368331192/jobs/5588961894
Fix (the timeout variable) is documented here.
https://github.com/actions/cache/blob/main/workarounds.md#cache-segment-restore-timeout
##########
.github/workflows/ci.yml:
##########
@@ -27,18 +27,10 @@ jobs:
name: Check
runs-on: ubuntu-20.04
steps:
- - uses: actions/setup-node@v3
- with:
- node-version: 16.15
- - name: Install Go
- uses: actions/setup-go@v2
- with:
- go-version: 1.19
- name: Check out code into the Go module directory
- uses: actions/checkout@v2
- - name: Check License Header
- run: make license-check
- - uses: actions/cache@v3
+ uses: actions/checkout@v3
+ - name: Cache Go Modules
+ uses: actions/cache@v3
Review Comment:
Hello, the timeout setting is not related to OAP itself but GitHub actions.
It should be used at any GitHub action step which involves downloading
artifact previously stored by the actions/cache@3. Otherwise, it might get
stuck for an hour. For example, in the OAP repo case it's used to retrieve the
cached infra-e2e build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
