kezhenxu94 commented on code in PR #9937:
URL: https://github.com/apache/skywalking/pull/9937#discussion_r1018686163
##########
test/e2e-v2/cases/mysql/mysql-slowsql/docker-compose.yaml:
##########
@@ -46,12 +46,34 @@ services:
- "MYSQL_ROOT_PASSWORD=password"
- "MYSQL_DATABASE=swtest"
ports:
- - 3306:3306
+ - 3306
healthcheck:
test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/3306"]
interval: 5s
timeout: 60s
retries: 120
+ mysql_2:
Review Comment:
Same here
##########
test/e2e-v2/cases/postgresql/postgres-exporter/docker-compose.yml:
##########
@@ -43,14 +43,44 @@ services:
command: postgres -c config_file=/etc/postgresql.conf
volumes:
- ./postgresql.conf:/etc/postgresql.conf
- - ./data:/var/lib/postgresql/data
networks:
- e2e
healthcheck:
test: ["CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/5432"]
interval: 5s
timeout: 60s
retries: 120
+ postgres_2:
+ image: postgres:14.1
+ environment:
+ - TZ=Asia/Shanghai
+ - POSTGRES_PASSWORD=123456
+ - POSTGRES_DB=skywalking
+ ports:
+ - 5432
+ command: postgres -c config_file=/etc/postgresql.conf
+ volumes:
+ - ./postgresql.conf:/etc/postgresql.conf
+ networks:
+ - e2e
+ healthcheck:
+ test: [ "CMD", "bash", "-c", "cat < /dev/null > /dev/tcp/127.0.0.1/5432"
]
+ interval: 5s
+ timeout: 60s
+ retries: 120
+ postgres_3:
+ image: postgres:14.1
+ environment:
+ - TZ=Asia/Shanghai
+ - POSTGRES_PASSWORD=123456
+ - POSTGRES_DB=skywalking
+ ports:
+ - 5432
+ command: postgres -c config_file=/etc/postgresql.conf
+ volumes:
+ - ./postgresql.conf:/etc/postgresql.conf
+ networks:
+ - e2e
Review Comment:
Please use anchor to reuse code snippets:
- Add `postgres: &psql` to line 35
```suggestion
postgres_2:
<<: *psql
postgres_3:
<<: *psql
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
