kezhenxu94 opened a new pull request, #9952:
URL: https://github.com/apache/skywalking/pull/9952
<!--
⚠️ Please make sure to read this template first, pull requests that
don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g.
<framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow
the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow
the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the
performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing
ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs.
<links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the
performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature,
follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature,
follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
This was introduced in https://github.com/apache/skywalking/pull/5238 and it
never works as expected so I just remove this and won't consider it as breaking
change.
In https://github.com/apache/skywalking/pull/5238 we meant to add
`lengthEnvVariable` as an mechanism to override the column length, but the env
var it uses is `SW_SLOW_DB_THRESHOLD`, which is the duration threshold instead
of length threshold, what's more, the content of `SW_SLOW_DB_THRESHOLD` is
something like `default:200,mongodb:100` but `StorageModels` always tries to
parse the content of `SW_SLOW_DB_THRESHOLD` as an integer, which causes the
following errors
```
2022-11-12 04:02:25,306
org.apache.skywalking.oap.server.core.storage.model.StorageModels 164 [main]
ERROR [] - [9.3.0-SNAPSHOT-7c8867b] Model [top_n_cache_read_command] Column
[statement], illegal value default:0,mongodb:100 of column length from system
env [SW_SLOW_DB_THRESHOLD]
2022-11-12 04:02:25,311
org.apache.skywalking.oap.server.core.storage.model.StorageModels 164 [main]
ERROR [] - [9.3.0-SNAPSHOT-7c8867b] Model [top_n_cache_write_command] Column
[statement], illegal value default:0,mongodb:100 of column length from system
env [SW_SLOW_DB_THRESHOLD]
2022-11-12 04:02:25,312
org.apache.skywalking.oap.server.core.storage.model.StorageModels 164 [main]
ERROR [] - [9.3.0-SNAPSHOT-7c8867b] Model [top_n_database_statement] Column
[statement], illegal value default:0,mongodb:100 of column length from system
env [SW_SLOW_DB_THRESHOLD]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
