wu-sheng commented on code in PR #9966:
URL: https://github.com/apache/skywalking/pull/9966#discussion_r1023564742
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -44,6 +44,9 @@ public BanyanDBIndexInstaller(Client client, ModuleManager
moduleManager, Banyan
@Override
public boolean isExists(Model model) throws StorageException {
+ if (!model.isTimeSeries()) { // UITemplate
+ return true;
+ }
Review Comment:
OK, I just noticed https://github.com/apache/skywalking/issues/9965.
I think we need to update the title a little. The correct one as title and
change log should be
`Fix not-time-series model blocking OAP boots in no-init mode`.
```suggestion
if (!model.isTimeSeries()) {
return true;
}
```
This comment is not necessary, we wouldn't remember to update this when we
add next new not-time-series model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
