This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 4ae167b850 Fix not-time-series model blocking OAP boots in no-init 
mode. (#9966)
4ae167b850 is described below

commit 4ae167b850bd152b5d1a628a03f3dfe50e97b08e
Author: Gao Hongtao <[email protected]>
AuthorDate: Wed Nov 16 17:23:22 2022 +0800

    Fix not-time-series model blocking OAP boots in no-init mode. (#9966)
---
 docs/en/changes/changes.md                                           | 1 +
 .../oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java   | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 27e3a79a66..cbbf5dce09 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -111,6 +111,7 @@
 * Remove `lengthEnvVariable` for `Column` as it never works as expected.
 * Add `LongText` to support longer logs persistent as a text type in 
ElasticSearch, instead of a keyword, to avoid length limitation.
 * Fix wrong system variable name 
`SW_CORE_ENABLE_ENDPOINT_NAME_GROUPING_BY_OPENAPI`. It was **opaenapi**.
+* Fix not-time-series model blocking OAP boots in no-init mode.
 
 #### UI
 
diff --git 
a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
 
b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
index 7a16eab863..d97c9a8699 100644
--- 
a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
+++ 
b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java
@@ -44,6 +44,9 @@ public class BanyanDBIndexInstaller extends ModelInstaller {
 
     @Override
     public boolean isExists(Model model) throws StorageException {
+        if (!model.isTimeSeries()) {
+            return true;
+        }
         final ConfigService configService = 
moduleManager.find(CoreModule.NAME).provider().getService(ConfigService.class);
         final MetadataRegistry.SchemaMetadata metadata = 
MetadataRegistry.INSTANCE.parseMetadata(model, config, configService);
         try {
@@ -87,7 +90,7 @@ public class BanyanDBIndexInstaller extends ModelInstaller {
                     log.info("install measure schema {}", model.getName());
                     ((BanyanDBStorageClient) client).define(measure);
                 }
-            } else if (!model.isTimeSeries()) { // UITemplate
+            } else if (!model.isTimeSeries()) {
                 log.info("skip property index {}", model.getName());
             }
         } catch (IOException ex) {

Reply via email to