mrproliu commented on code in PR #58:
URL: https://github.com/apache/skywalking-rover/pull/58#discussion_r1025030060
##########
pkg/profiling/task/network/analyze/layer7/protocols/base/tracing.go:
##########
@@ -15,23 +15,32 @@
// specific language governing permissions and limitations
// under the License.
-package protocols
+package base
import (
"encoding/base64"
"fmt"
"strings"
+
+ v3 "skywalking.apache.org/repo/goapi/collect/language/agent/v3"
)
type TracingContext interface {
TraceID() string
- Provider() string
+ TraceSegmentID() string
+ SpanID() string
+ Provider() *TraceContextProvider
+}
+
+type TraceContextProvider struct {
+ Type v3.SpanAttachedEvent_SpanReferenceType
+ Name string
}
type SkyWalkingTracingContext struct {
TraceID0 string
- SegmentID string
- SpanID string
+ SegmentID0 string
+ SpanID0 string
Review Comment:
That's used to avoid conflict between field and method.
##########
pkg/profiling/task/network/analyze/layer7/protocols/http1/analyzer_test.go:
##########
@@ -243,19 +245,19 @@ func TestBuildHTTP1(t *testing.T) {
for _, testCase := range tests {
//t.Run(testCase.name, func(t *testing.T) {
- analyzer := NewHTTP1Analyzer().(*HTTP1Analyzer)
+ analyzer := NewHTTP1Analyzer().(*Analyzer)
l := list.New()
var events = make([]struct {
start, end int
}, 0)
for _, event := range testCase.events {
- req, resp := analyzer.buildHTTP1(l,
&SocketDataUploadEvent{
- DataID: uint64(event.dataID),
- MsgType:
base.SocketMessageType(event.dataType),
- Sequence: uint16(event.sequence),
- Finished: uint8(event.finished),
- Buffer: bufferConvert(event.data),
- DataLen: uint16(len(event.data)),
+ req, resp := analyzer.buildHTTP1(l,
&base2.SocketDataUploadEvent{
+ DataID: uint64(event.dataID),
+ MsgType:
base.SocketMessageType(event.dataType),
+ Sequence: uint16(event.sequence),
+ FinishStatus: uint8(event.finished),
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
