wu-sheng commented on code in PR #10002:
URL: https://github.com/apache/skywalking/pull/10002#discussion_r1029036891
##########
apm-protocol/apm-network/src/main/java/org/apache/skywalking/oap/server/network/trace/component/command/EBPFProfilingTaskCommand.java:
##########
@@ -39,10 +39,11 @@ public class EBPFProfilingTaskCommand extends BaseCommand
implements Serializabl
private String triggerType;
private FixedTrigger fixedTrigger;
private String targetType;
+ private String extensionConfigJson;
public EBPFProfilingTaskCommand(String serialNumber, String taskId,
List<String> processIdList, long taskStartTime,
long taskUpdateTime, String triggerType,
FixedTrigger fixedTrigger,
- String targetType) {
+ String targetType, String
extensionConfigJson) {
Review Comment:
I prefer we use static fields rather than JSON. EBPFProfilingTaskCommand is
going to put attributes into a key-value pair, and adding a new JSON seems wire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
