lujiajing1126 commented on code in PR #10019:
URL: https://github.com/apache/skywalking/pull/10019#discussion_r1031214171


##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBConverter.java:
##########
@@ -67,9 +67,13 @@ public byte[] getBytes(String fieldName) {
     public static class StreamToStorage implements 
Convert2Storage<StreamWrite> {
         private final MetadataRegistry.Schema schema;
         private final StreamWrite streamWrite;
+        private final String timestampColumn;

Review Comment:
   I suppose this field can be incorporated into the `MetadataRegistry.Schema` 
during the model parse, so we don't need this field here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to