wu-sheng commented on code in PR #10085: URL: https://github.com/apache/skywalking/pull/10085#discussion_r1039067178
########## docs/en/changes/changes.md: ########## @@ -7,6 +7,20 @@ * Add `ServerStatusService` in the core module to provide a new way to expose booting status to other modules. * Adds Micrometer as a new component.(ID=141) * Refactor session cache in MetricsPersistentWorker. +* Cache enhancement - don't read new metrics from database in minute dimensionality. +``` + // When + // (1) the time bucket of the server's latest stability status is provided + // 1.1 the OAP has booted successfully + // 1.2 the current dimensionality is in minute. Review Comment: @wankai123 1.3 should be related to #10076 ``` 1.3 the OAP cluster is rebalanced due to scaleing ``` ########## docs/en/changes/changes.md: ########## @@ -7,6 +7,20 @@ * Add `ServerStatusService` in the core module to provide a new way to expose booting status to other modules. * Adds Micrometer as a new component.(ID=141) * Refactor session cache in MetricsPersistentWorker. +* Cache enhancement - don't read new metrics from database in minute dimensionality. +``` + // When + // (1) the time bucket of the server's latest stability status is provided + // 1.1 the OAP has booted successfully + // 1.2 the current dimensionality is in minute. Review Comment: @wankai123 1.3 should be related to #10076 ``` 1.3 the OAP cluster is rebalanced due to scaling ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
