wu-sheng commented on PR #10098:
URL: https://github.com/apache/skywalking/pull/10098#issuecomment-1337579422
```
- map[interface{}]interface{}{
- string("detectpoints"):
[]interface{}{string("CLIENT")},
- string("id"):
string("a6998b690466d1d80fa9379dafd9145d6a6d8b45ab49949c9405ddecd169960d-b456c20e471dc1ca4dfa06529b6e3cf320916c49bd12dcd847de8856ab321fd3"),
- string("source"):
string("a6998b690466d1d80fa9379dafd9145d6a6d8b45ab49949c9405ddecd169960d"),
- string("sourcecomponents"):
[]interface{}{string("tcp")},
- string("target"):
string("b456c20e471dc1ca4dfa06529b6e3cf320916c49bd12dcd847de8856ab321fd3"),
- string("targetcomponents"): []interface{}{},
- },
+ map[interface{}]interface{}{
+ string("detectpoints"):
[]interface{}{string("CLIENT"), string("SERVER")},
+ string("id"):
string("a6998b690466d1d80fa9379dafd9145d6a6d8b45ab49949c9405ddecd169960d-e68bf4959a6e1d10f6d9032662f1187f0325[445](https://github.com/apache/skywalking/actions/runs/3620492727/jobs/6104321005#step:7:452)a348bd5708a4f87e71420d3bb"),
+ string("source"):
string("a6998b690466d1d80fa9379dafd9145d6a6d8b45ab49949c9405ddecd169960d"),
+ string("sourcecomponents"):
[]interface{}{string("http")},
+ string("target"):
string("e68bf4959a6e1d10f6d9032662f1187f0325445a348bd5708a4f87e71420d3bb"),
+ string("targetcomponents"):
[]interface{}{string("http")},
```
It seems this relationship query logic is not correct. You never put the
component ID in the ID.
Because I remove metrics persistent offsite, there is no guarantee there is
TCP or HTTP component ID in the relationship. I think you should either
1. Support component IDs as a list, and support update when new component ID
is added
2. Put the component ID in the ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
