This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 960aa9ffe1 Fix some metrics session wouldn't expire after TTL. (#10159)
960aa9ffe1 is described below

commit 960aa9ffe182293bb852e8c3b550542c3bd1ecb8
Author: Wan Kai <[email protected]>
AuthorDate: Thu Dec 15 14:48:17 2022 +0800

    Fix some metrics session wouldn't expire after TTL. (#10159)
---
 .../oap/server/core/analysis/worker/MetricsPersistentWorker.java        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
index fc0865a867..bff0879297 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
@@ -320,7 +320,7 @@ public class MetricsPersistentWorker extends 
PersistenceWorker<Metrics> {
                            // This is a cache-DB inconsistent case:
                            // Metrics keep coming due to traffic, but the 
entity in the
                            // database has been removed due to TTL.
-                           if (!model.isTimeRelativeID() && supportUpdate) {
+                           if (!model.isTimeRelativeID()) {
                                // Mostly all updatable metadata level metrics 
are required to do this check.
 
                                if (metricsDAO.isExpiredCache(model, 
cachedValue, currentTimeMillis, metricsDataTTL)) {

Reply via email to