wu-sheng commented on a change in pull request #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#discussion_r312468849
########## File path: apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/undertow/v2x/handler/TracingHandler.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.skywalking.apm.plugin.undertow.v2x.handler; + +import io.undertow.server.ExchangeCompletionListener; +import io.undertow.server.HttpHandler; +import io.undertow.server.HttpServerExchange; +import io.undertow.util.HeaderMap; +import org.apache.skywalking.apm.agent.core.context.CarrierItem; +import org.apache.skywalking.apm.agent.core.context.ContextCarrier; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.tag.Tags; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; +import org.apache.skywalking.apm.plugin.undertow.v2x.Constants; + +/** + * @author AI + * 2019-08-06 + */ +public class TracingHandler implements HttpHandler { + private final String template; + private final HttpHandler next; + + public TracingHandler(HttpHandler handler) { + this(null, handler); + } + + + public TracingHandler(String template, HttpHandler handler) { + this.next = handler; + this.template = template; + } + + @Override + public void handleRequest(HttpServerExchange exchange) throws Exception { + final HeaderMap headers = exchange.getRequestHeaders(); + final ContextCarrier carrier = new ContextCarrier(); + CarrierItem items = carrier.items(); + while (items.hasNext()) { + items = items.next(); + items.setHeadValue(headers.getFirst(items.getHeadKey())); + } + String operationName; + if (null == template) { + operationName = exchange.getRequestPath(); + } else { + operationName = template; + } + final AbstractSpan span = ContextManager.createEntrySpan(operationName, carrier); + Tags.URL.set(span, exchange.getRequestURL()); + Tags.HTTP.METHOD.set(span, exchange.getRequestMethod().toString()); + span.setComponent(ComponentsDefine.UNDERTOW); + SpanLayer.asHttp(span); + span.prepareForAsync(); + exchange.addExchangeCompleteListener(new ExchangeCompletionListener() { + @Override + public void exchangeEvent(HttpServerExchange httpServerExchange, NextListener nextListener) { + if (httpServerExchange.getStatusCode() >= 400) { + span.errorOccurred(); + Tags.STATUS_CODE.set(span, Integer.toString(httpServerExchange.getStatusCode())); + } + span.asyncFinish(); + nextListener.proceed(); Review comment: Is this order right? Should span duration include nextListener? If YES, you need to consider try/finally, because, nextListener could be failure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
