nisiyong commented on PR #428: URL: https://github.com/apache/skywalking-java/pull/428#issuecomment-1365182872
> It seems the OAP side will calculate GC time per second. This change should consider more. @dylanforest @wu-sheng Sorry for my late reply, this PR looks good to me. And I should correct what I said before, the agent side will calculate the GC time rather than the OAP side. https://github.com/apache/skywalking-java/blob/cd84ba2167fd2ca7ccd8531b035d390fadd582a9/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/gc/GCModule.java#L56 Currently, the metrics are stored at a minute level in the backend, so I think this is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
