mufiye commented on issue #9999:
URL: https://github.com/apache/skywalking/issues/9999#issuecomment-1374763629
Good afternoon, @wu-sheng . Now I'm writing the code of the outer API first,
but I encounter some problems:
* First is the `SpanRef` how to point to the real span, the method I think
is embedding a real span attribute `span` into the `SpanRef` object. WDYT?
* Then we should import the `AsyncSpan` class into the `SpanRef` class. Is
it allowed to import internal packages like this? Also for the
`ContextSnapshot` imported into the `Tracer` class for `capture` and
`continued` methods.
* And for the `SpanRef` idea, I want to merge `AsyncSpanRef` and `SpanRef`
proposed originally into the `SpanRef` showing as below codes. WDYT?
'''
import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
public class SpanRef {
private AsyncSpan span;
public SpanRef(AsyncSpan span) {
this.span = span;
}
public SpanRef prepareForAsync() {
return null;
}
public SpanRef asyncFinish() {
return null;
}
public void log(Throwable t) {
}
public void log(Map<String, ?> event) {
}
}
'''
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
