pg-yang commented on code in PR #438:
URL: https://github.com/apache/skywalking-java/pull/438#discussion_r1065715092
##########
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedisConnectionMethodInterceptor.java:
##########
@@ -70,16 +75,22 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
}
} else if (allArguments[0] instanceof CommandData) {
CommandData commandData = (CommandData) allArguments[0];
- String command = commandData.getCommand().getName();
- operationName = operationName + command;
- addCommandData(dbStatement, commandData);
+ methodName = commandData.getCommand().getName();
+ operationName = operationName + methodName;
+ arguments = commandData.getParams();
}
AbstractSpan span = ContextManager.createExitSpan(operationName, peer);
span.setComponent(ComponentsDefine.REDISSON);
- Tags.DB_TYPE.set(span, "Redis");
+ Tags.CACHE_TYPE.set(span, "Redis");
Tags.DB_INSTANCE.set(span, dbInstance);
Review Comment:
I think `Tags.DB_STATEMENT` could be removed, `DB_STATEMENT= cache.cmd +
cache.key`. Right?
For `DB_INSTANCE`, how about we add a tag `CACHE_INSTANCE` to indicate which
cache node is requested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
