kezhenxu94 commented on code in PR #444:
URL: https://github.com/apache/skywalking-java/pull/444#discussion_r1091560039
##########
pom.xml:
##########
@@ -345,24 +361,28 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
- <source>${compiler.version}</source>
+ <source>
Review Comment:
I reverted the `<release>` back to `<source>` and `<target>` as that won't
compile in our case, and because the plugin tests are still run in Java 8
that's OK enough to ensure we don't use APIs from > Java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
