Superskyyy commented on issue #10334: URL: https://github.com/apache/skywalking/issues/10334#issuecomment-1416662376
> About feature, I would follow these steps: > > 1. Create a `sw_loguru` module in `skywalking.log` package. > 2. Move `sw_logging.transform` function to `log.formatter` module. > 3. Move `build_log_tags` function from `sw_logging` to `log.formatter` module. > > Is there anything inappropriate ？ And I will think about test part a little latter. Hope for your suggestion. @Superskyyy That sounds great. I guess the other important thing is to see if loguru and sw_logging can co-exist, if they produce duplicated results you will need to provide a configuration to disable one of them. I don't know how lorugu works though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
